McJtyMods / XNet

Advanced item/liquid/energy/... networking
MIT License
92 stars 53 forks source link

enable on color ignored in latest version ? #594

Closed Mekanofreak closed 3 months ago

Mekanofreak commented 3 months ago

Issue description: Xnet seem to just ignore the "enable on color" option in latest version

Steps to reproduce: Created a new world, using only the latest version of Xnet and Mekanism for power. Placed a controller and 3 chest, connected them all with advanced connector.

Capture d’écran 2024-06-27 010648

Setup a logic channel so that chest 1 output "white" if number of items is not 0 (!= 0)

Capture d’écran 2024-06-27 010659

filled chest number 2 with a stack of iron, create an "item" channel, set the connector to extract and setting "enable on color" to white and set chest number 3 to insert

Capture d’écran 2024-06-27 010707

Now with chest number one empty (so no "white" output ) chest number 2 items are still behing extracted to chest number 3. Completely removing the logic channel changes nothing, changing the color of the "enable on color" neither.

Reverting back to Xnet 6.1.2 using the exact same setup everything work as expected and items are extracted form chest number 2 only if chest number 1 contains items.

Versions:

Dertiende commented 3 months ago

Hi, in your picture you can see that the chest connector has the "ignore redstone signal" mode, so the connector doesn't care if there is a signal, even if the color is set. After the last update this became important

Dertiende commented 3 months ago

You may read about all changes here https://github.com/McJtyMods/XNet/pull/591#issue-2358002845

Mekanofreak commented 3 months ago

Ok, will advise the player on my ATM9 server, brought this up since it broke most of their Xnet setup on the last modpack update

Mekanofreak commented 3 months ago

Just to be clear on the change, does that mean that now you can't use redstone and color controls at the same time on a connector ? I don't know if I describe it right but can we setup a connector to work on receiving a "white" output and a redstone signal ?

Mekanofreak commented 3 months ago

Sorry I reread the description and I think I understand now, my english is not so good. thanks for the help

Dertiende commented 3 months ago

You can connect the redstone signal to another connector and also set it to output a white signal.

Dertiende commented 3 months ago

Pls close the issue if problem solved

Mekanofreak commented 3 months ago

Problem solved