search

McKael / madonctl

CLI client for the Mastodon social network API
MIT License
193 stars 9 forks source link

v2.3.1 fails to build from source due to changes in github.com/McKael/madon #17

Closed nilium closed 1 year ago

nilium commented 5 years ago

This appears to be due to a change in the github.com/McKael/madon dependency, which wasn't vendored in v2.3.1. I'm not certain what versions of madonctl's dependencies were used to build it, otherwise I'd submit a patch for that. Would it be reasonable to cut a v2.3.2 patch release with vendored dependencies so that it can be built from source until a stable release of v2.4.0 is ready? Otherwise, if it's best to wait until v2.4.0, that's probably fine.

The following is what you'll see if building v2.3.1 from source currently:

# github.com/McKael/madonctl/cmd
_build-madonctl-xbps/src/github.com/McKael/madonctl/cmd/accounts.go:656:39: too many arguments in call to gClient.UpdateAccount
        have (*string, *string, *string, *string, *bool)
        want (madon.UpdateAccountParams)
_build-madonctl-xbps/src/github.com/McKael/madonctl/cmd/toot.go:150:27: too many arguments in call to gClient.PostStatus
        have (string, int64, []int64, bool, string, string)
        want (madon.PostStatusParams)
McKael commented 5 years ago

That's right, I've added Go modules support in the master branch but I have not made a release since then... I'll try to do it in a few days. The current master branch should build fine if you use Go modules. FWIW, madonctl 2.3.1 was built with madon v. 2.3.0 IIRC.

(Sorry for the delay!)

nilium commented 5 years ago

In this case, I can’t use unstable branches for packages, so there would need to be a new release with vendored dependencies or a correct go.mod file (ideally one with both). I’ll keep an eye out for a release in the meantime. Thanks!

r3k2 commented 5 years ago

you could start using GO modules :)

bsiegert commented 3 years ago

Could you please cut a 2.3.2 release? Thanks!

Anachron commented 2 years ago

@McKael please tag a 2.3.2 release so we can package it again.

McKael commented 2 years ago

Oh, yeah, sorry! And thanks for the reminder!

McKael commented 2 years ago

I've just updated the modules and tagged a 2.3.2 release as requested. Sorry again for the delay.

Anachron commented 2 years ago

NP and thanks!

nilium commented 2 years ago

Do I get to close this almost 4 years later?