search

McKael / samtv

samtvcli -- Network CLI remote for Samsung TVs (models 2014-2015)
https://lilotux.net/~mikael/pub/samtv/
MIT License
40 stars 4 forks source link

pin entry fails if pin contains leading zeros #13

Open barfnordsen opened 1 year ago

barfnordsen commented 1 year ago

samtvcli pair --pin 0077 Error: invalid argument "0077" for "--pin" flag: strconv.ParseInt: parsing "0077": invalid syntax

McKael commented 1 year ago

I cannot reproduce with "0077" but, indeed, the logic is buggy when the PIN code starts with a 0 (and... the flag library seems to parse the number as an octal value, so 0123 would be converted to 83, and "0876" can't be parsed).

I've never had a PIN code starting with a 0 on my Samsung (and I've tried without success), did you really get "0077"? (I still don't understand why 0077 would trigger this error message.)

barfnordsen commented 1 year ago

i got a few with leading zeros. i remember got 0088. not sure about 0077. but my tv showed every second or third pairing attempt a pin with leading zeros. resulting in this error everytime.

found this in my windows shell: .\samtvcli.exe pair --pin 0091 Error: invalid argument "0091" for "--pin" flag: strconv.ParseInt: parsing "0091": invalid syntax

i then switched to linux, hoping its just a windows issue. but had same issues.

McKael commented 1 year ago

Okay, 0088 would explain this error message.

I'll switch the flag to a string (it makes more sense anyway)... Thanks for the report!

barfnordsen commented 1 year ago

Thank you :)