search

McKay42 / McOsu

Custom unofficial osu! practice client with Virtual Reality support
GNU General Public License v3.0
426 stars 40 forks source link

spinner-background.png is not being drawn #352

Closed resolritter closed 1 year ago

resolritter commented 1 year ago

I think spinner-background.png is not being drawn. My conclusion comes from this part of the code:

https://github.com/McKay42/McOsu/blob/2f22a941b84d093614a27bb255defb7a76dfc5aa/src/App/Osu/OsuSpinner.cpp#L99

The code checks if spinner-background.png was loaded (skin->getSpinnerBackground() != skin->getMissingTexture()), but apparently doesn't do anything with the asset within the if's body.

Reference: https://osu.ppy.sh/wiki/en/Skinning/osu%21

McKay42 commented 1 year ago

The check is only used to detect old style spinners in skins, which are not implemented/supported. Everything inside the if-block for the "old style" spinners is just a workaround so skins with old style skins show something playable at all instead of being invisible.

Unless you intend to write the code for supporting old style spinners fully properly this is not going to change.