Probable bug in FRAMEWRK.c (MS Excel plug-in framework)

McLeodMoores / xl4j

Framework for writing Excel Add-ins in Java

Other

7 stars 3 forks source link

Closed jimmoores closed 7 years ago

jimmoores commented 8 years ago

Just reviwing the code, I notice on line 705 of FRAMEWRK.c

lps[0] = (BYTE)len;

I believe this should be:

lps[0] = (XCHAR)len; // or (unsigned short) or (WORD) or something

as it will corrupt the length of any strings over 255 characters.

jimmoores commented 7 years ago

This IS a bug in FRAMEWRK.c, so we've fixed it and are using it.