search

McLeodMoores / xl4j

Framework for writing Excel Add-ins in Java
Other
7 stars 3 forks source link

Is there a way to check uniqueness of function names and warn? #68

Open emcleod opened 8 years ago

emcleod commented 8 years ago

Randomly (or not) only choosing one is confusing at best

jimmoores commented 8 years ago

Of course, just check existing ones or get the factory to maintain a set.

jimmoores commented 8 years ago

It really should warn at an absolute minimum. At the moment, it just ignores and uses the last one found.

emcleod commented 7 years ago

Added a test in FunctionRegistry.scanAndCreateFunctions(). Currently only a WARN is done. Comparison on function names is case-insensitive, as I think it's true that Excel is case-insensitive.

I didn't change the overwriting behaviour, however, so the warning message is given and then the function is added anyway.