search

McModLauncher / modlauncher

Java 21 mod launcher
Other
171 stars 47 forks source link

Add some tweaks to improve transformation time #16

Closed ichttt closed 5 years ago

ichttt commented 5 years ago

Add some additional checks so the classwriter is not used if possible, as classwriting with computing frames can take some time, and avoiding creating a new arraylist if no transformers are present. Nearly cuts the time spend on transforming classes in half with some changes to forge to return a null ClassNode when nothing is transformed (About 1.5 seconds total to 2.8 spend on ClassTransformer#transform).

cpw commented 5 years ago

Sadly, I disagree with how this is implemented. I get your feedback, and I'll definitely look at ways to improve the transformation time.