search

McModLauncher / modlauncher

Java 21 mod launcher
Other
171 stars 47 forks source link

Transformation cache #3

Closed ichttt closed 7 years ago

ichttt commented 7 years ago

This PR enables some caching in the modlauncher. There are many parts that need to be cleaned up like hardcoded dirs or the add url part, but I still wanted to open this PR to get some reviewers to look over the basic concept. Pinging @asiekierka as he made something like this with his classCacheTweaker. Looking forward to get some reviews, as this might improve loading times of large modpacks significantly.

asiekierka commented 7 years ago

Pinging @nallar as I took the initial idea from him

LunNova commented 7 years ago

Thanks for the ping asie.

Haven't had time to look at the code here but it'd be great to integrate caching into the replacement for legacy launcher - it's a lot easier to do correctly if transformers expect their results to be cached and there's a proper API for indicating when the cache should be invalidated.

cpw commented 7 years ago

I'm going to close this PR. The code isn't quite going in this direction at present. I agree caching is probably something desireable, but there's a lot of issues around it that need to be figured out. This will be a revisited topic however.