Update ASM API version to support J17 features

zml2008 commented 2 years ago

The new ASM API changes do not impact our current uses, so this is a straightforward version bump.

From an analysis of these uses posted in the #mcmodlauncher discord channel:

ClassTransformer: just creating a ClassNode, seems like if ClassNode correctly overrides every visit method, the api version constant is never checked
PredicateVisitor: changes to visit/visitField/visitMethod, none of which have changed behavior between 7 and 9
TransformerClassWriter$SuperCollectingVisitor: any changes in inheritance behavior. sealed classes and records both have specific inheritance constraints, but none affect the information collected from this visitor

Fixes #74

williewillus commented 2 years ago

Bumping this, it's blocking Botania's continued porting work for forge 1.18

marchermans commented 2 years ago

@zml2008 All commits need to be signed. So please resign your commits and force push to your fork.

cpw commented 2 years ago

@zml2008 please sign this commit.

zml2008 commented 2 years ago

Commits were already signed, added a UID for the email i'm using here to the key on GH, so should be good to go with no changes to the commits.

McModLauncher / modlauncher