search

McParen / croatoan

This repository has been migrated to Codeberg.
Other
147 stars 13 forks source link

fixed 'complex-char=', taking into accounts attributes slot. #20

Closed cage2 closed 4 years ago

cage2 commented 4 years ago

Hi! this hopefully fix the problem in #19 .

Also i have added set=, this is a general utility maybe that could placed elsewhere, util.lisp peraphs?

Bye! C.

McParen commented 4 years ago

I've found that set-equal has ben handled in Common Lisp Recipes. Instead of set-difference, Weitz uses set-exclusive-or. set-difference isnt suitable when list-a is longer than list-b, it just subtracts b from a. I've renamed set= to set-equal, because = is usually reserved for numerical arguments. Thanks for your quick response.

cage2 commented 4 years ago

On Sat, Dec 21, 2019 at 01:13:51PM -0800, McParen wrote:

Hello!

I've found that set-equal has ben handled in Common Lisp Recipes. Instead of set-difference, Weitz uses set-exclusive-or. set-difference isnt suitable when list-a is longer than list-b, it just subtracts b from a.

Ah i see! So the function 'set-difference' is not the simmetric difference, it is the complement, is it? Then i read the documentation (hyperspec) wrong. :(

I've renamed set= to set-equal, because = is usually reserved for numerical arguments.

Right!

Thanks for your quick response.

You're welcome!

Bye! C.

PS: thank you also for remind me about the precious Weitz book! :)