search

McParen / croatoan

This repository has been migrated to Codeberg.
Other
147 stars 13 forks source link

Added 'concat-complex-string' method specialized on sequence complex-string #38

Closed cage2 closed 4 years ago

cage2 commented 4 years ago

Hi @McParen !

I just realized concat-complex-string does not permits to append a a complex-string to a string.

I just guessed was a good idea to add this missing method. :-)

Bye! C.

McParen commented 4 years ago

Hello cage, nice to hear from you, thanks for taking care of that part.

Can you check the docstring for concat-complex-string? I think the descriptions for a' andb' have to be swapped.

cage2 commented 4 years ago

Hello cage, Hi @McParen

nice to hear from you, thanks for taking care of that part.

My pleasure! Honestly I do not know why i did not added that method in the first PR. Probably i was just lazy! :)

Can you check the docstring for concat-complex-string? I think the descriptions for a' andb' have to be swapped.

Sure! The doc string was wrong, like you wrote above the arguments was swapped, indeed.

Bye!! C.

McParen commented 4 years ago

I squashed the last two commits into the first commit, then merged. Github doesn't seem to close the PR automatically in that case. Thanks and bye!

cage2 commented 4 years ago

On Sat, Oct 17, 2020 at 07:15:18AM -0700, McParen wrote:

Hi McParen!

I squashed the last two commits into the first commit, then merged. Github doesn't seem to close the PR automatically in that case. Thanks and bye!

No problem, in this case squash the commits was a good idea anyway! Thank you for merging! :)

Take care! C.