McParen / croatoan

This repository has been migrated to Codeberg.
Other
147 stars 13 forks source link

Fixed array-slice #40

Closed cage2 closed 3 years ago

cage2 commented 3 years ago

Hi @McParen !

The function array-slice' was allocating a results vector as big as the input when the parameter end was null.

This would gives wrong results when the parameter start was > 0 (the majority of the call to this function is called, i think).

This patch try to takes into account the parameter end when is null and allocates a correctly sized resulting array.

Also a few trailing spaces deleted by Emacs. :)

Bye! C.

McParen commented 3 years ago

Hello cage, nice to hear from you again. Thanks for the patch, will apply.

Also a few trailing spaces

Not the first and not the last. ;)

deleted by Emacs

Thanks for that hint. I wasnt even aware of show-trailing-whitespace and delete-trailing-whitespace and have been leaving them all over the place. Better late than never, I suppose.

cage2 commented 3 years ago

On Mon, Jun 28, 2021 at 11:15:06AM -0700, McParen wrote:

Hello cage,

Hi!

nice to hear from you again.

Thank you, i hope you are fine in these weird times!

Thanks for the patch, will apply.

Thank to you, i wish i could contribute more but for now i can only fix bugs that very likely i introduced before. :)

Also a few trailing spaces

Not the first and not the last. ;)

deleted by Emacs

Thanks for that hint. I wasnt even aware of show-trailing-whitespace and delete-trailing-whitespace and have been leaving them all over the place. Better late than never, I suppose.

I can't remember who suggested me to use these commands but i am quite sure if was not for them i would left withespaces scattered everywhere in all my files! :)

Bye McParen and take care! C.