search

McParen / croatoan

This repository has been migrated to Codeberg.
Other
147 stars 13 forks source link

#\horizontal_ellipsis is not recognized by some implementations #53

Closed Yehouda closed 1 year ago

Yehouda commented 1 year ago

https://github.com/McParen/croatoan/blob/8a36ee126ee6be41dd9ab65a0b8a1b5a0080c6a3/src/menu.lisp#L111

\horizontal_ellipsis is not a standard character is common-lisp, so will not be recognize by some implementations and wil get an error.

replacing it by (code-char #x2026) make it poratble for all implementations.

Maybe make clearer to read by defining

(defconstant *horizontal-ellipsis-char* (code-char #x2026))

and then use *horizontal-ellipsis-char*.

McParen commented 1 year ago

Hello Yehouda,

although I am not able to perform tests on all implementations for time constraint reasons, I will gladly accept suggestions to make the library run on as many implementations as possible. So thank you very much for your contribution, I will include it with the next patch. You are welcome suggesting further changes and making your implementation run the code well.

Kind regards.

McParen commented 1 year ago

I think I have solved your issue with the above patch, thanks for testing the library with LW and reporting.