search

McSinyx / comp

Migrated to https://git.sr.ht/~cnx/comp
https://pypi.org/project/comp/
GNU Affero General Public License v3.0
15 stars 1 forks source link

import curses, re in omp/omp.py #9

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

flake8 testing of https://github.com/McSinyx/comp on Python 3.6.3

This PR fixes 4 of the 6 reported missing names...

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./omp/omp.py:73:22: F821 undefined name 'Comp'
        self = super(Comp, cls).__new__(cls)
                     ^
./omp/omp.py:120:67: F821 undefined name 'value'
                _("Failed to multiply '{}' with {}").format(name, value),
                                                                  ^
./omp/omp.py:183:13: F821 undefined name 're'
        p = re.compile(self.gets('/'), re.IGNORECASE)
            ^
./omp/omp.py:183:40: F821 undefined name 're'
        p = re.compile(self.gets('/'), re.IGNORECASE)
                                       ^
./omp/omp.py:192:56: F821 undefined name 'curses'
            self.update_status(_("Pattern not found"), curses.color_pair(1))
                                                       ^
./omp/omp.py:200:56: F821 undefined name 'curses'
            self.update_status(_("Pattern not found"), curses.color_pair(1))
                                                       ^
6     F821 undefined name 'Comp'
6
McSinyx commented 6 years ago

Thank you, merged. I am so happy that Omp didn't got far enough that sb used as a library. Damn careless me.

cclauss commented 6 years ago

The Comp and value issues were not fixed in this PR.

McSinyx commented 6 years ago

Thank you, I've just fixed that by 5dc1184.