"Settings" tab is not shown

McSodbrenner / vscode-better-open-editors

MIT License

14 stars 7 forks source link

"Settings" tab is not shown #5

Open McSodbrenner opened 2 years ago

McSodbrenner commented 2 years ago

The API does not return a valid "input" value for this tab. The corresponding upstream issue should be linked here.

McSodbrenner commented 2 years ago

Upstream issue created:

[ ] https://github.com/microsoft/vscode/issues/158853

McSodbrenner commented 2 years ago

The same is true for the Markdown Preview. There tab.input only contains the corresponding viewType, but no information about which file the preview belongs to. So you cannot show the tab with vscode.open nor with vscode.window.showTextDocument.

OrkWard commented 1 year ago

Why not just list all these special tabs like settings/plugin/shortcut apart, for example below other tabs or above? In current version they just don't show up, if any of them opened the plugin will crash(reference of input, which is undefined) I'm glad to implement this feature and #19 too in my spare time