McStas 3.0: Scoping-issue in ESS_butterfly on macOS (potentially also other non-OpenACC platforms) - Githubissues

McStasMcXtrace / McCode

The home of the McStas (neutrons) and McXtrace (x-rays) Monte-Carlo ray-tracing instrument simulation codes.

https://github.com/McStasMcXtrace/McCode/wiki

GNU General Public License v3.0

77 stars 54 forks source link

McStas 3.0: Scoping-issue in ESS_butterfly on macOS (potentially also other non-OpenACC platforms) #1098

Closed willend closed 2 years ago

willend commented 3 years ago

From clang on macOS

./ESS_butterfly_test.c:16276:1: error: function definition is not allowed here
{
^
./ESS_butterfly_test.c:16453:3: error: implicit declaration of function 'butterfly_geometry' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  butterfly_geometry(delta_y, jmax, cx, cz,
  ^
47 warnings and 2 errors generated.

somehow the function called in the DISPLAY section looks like an implicit declaration. It is puzzling why this is not visible on http://new-nightly.mccode.org/2021-01-21/2021-01-21_output.html

willend commented 3 years ago

Has been fixed on mcstas-3.0