McStasMcXtrace / McCode

The home of the McStas (neutrons) and McXtrace (x-rays) Monte-Carlo ray-tracing instrument simulation codes.
https://github.com/McStasMcXtrace/McCode/wiki
GNU General Public License v3.0
77 stars 54 forks source link

McXtrace 3: Multiple issues with NBI_Lab_tomo.instr #1217

Open willend opened 2 years ago

willend commented 2 years ago

See http://new-nightly.mcxtrace.org/2022-02-27/overview.html

Zero intensity on multiple monitors, further issues on GPU than CPU.

Initial investigations point in the direction of read-table_lib, especially re-used and re-binned tables, looks to be material-dependent. Unit tests should be expanded for Filter.comp.

Potential related issues on master branch also.

willend commented 2 years ago

%Example list now expanded, see https://github.com/McStasMcXtrace/McCode/commit/9149d61ff90a681f82f2d26d5530b9b9e59afea3

willend commented 2 years ago

Filter test instrument outputs after addition of tests demonstrate that there is also an issue on master: (1.x left 3.x CPU right)

Screenshot 2022-02-27 at 10 06 59
willend commented 2 years ago

It seems that the recent commit relating to Filter.comp fixes Test_Filter: Screenshot 2022-03-03 at 09 51 51

and the changes to NBI_Lab_TOMO should give status "green" from within tomorrow's test

NVC++-W-0155-Upcoming behavior change: array reference in data/update clause with no triplet notation will be treated as an array element in a future release: ..inline (NBI_Lab_TOMO.c: 10566)
NVC++-W-0155-Upcoming behavior change: array reference in data/update clause with no triplet notation will be treated as an array element in a future release: ..inline (NBI_Lab_TOMO.c: 10566)
NVC++/x86-64 Linux 21.7-0: compilation completed with warnings
[OK] NBI_Lab_TOMO: Detector_Si_I = 3.88216e+13 +/- 58185000000, equals 3.9e+13
 within 1 %
Executing: mxrun.pl NBI_Lab_TOMO.instr  fname="spectrumU50_th5.dat" -n 1000000 --format=PGPLOT -d NBI_Lab_TOMO/1
[OK] NBI_Lab_TOMO: Detector_Si_I = 9.86322e+11 +/- 1537330000, equals 9.87e+11
 within 1 %
Test Abstract for selftest_xSNH
[OK]     NBI_Lab_TOMO_1 (accuracy, 1 %)
[OK]     NBI_Lab_TOMO_2 (accuracy, 1 %)

# Execution check:    OK.     Computing time: 82 [sec] for 2 tests.
# Accuracy check:     OK.
# End Date: Thu Mar  3 09:45:54 2022