McStasMcXtrace / McCode

The home of the McStas (neutrons) and McXtrace (x-rays) Monte-Carlo ray-tracing instrument simulation codes.
https://github.com/McStasMcXtrace/McCode/wiki
GNU General Public License v3.0
78 stars 54 forks source link

Monochromator_bent not working for negative bending radii, and other configurations. Also yielding wrong results with multiple lamella. #1720

Open Lomholy opened 1 month ago

Lomholy commented 1 month ago

When setting a negative bending radius an error is currently given, but many other configurations that should be working with the component have not been tested and are also probable to fail without proper warning.

Using multiple lamella produces different results then expected, so care should be taken with results generated from anything that is not just a single slab, reflecting neutrons from the front, such as in the "Test_monochromator_bent.instr".

Me and Jan will work on fixing these problems, and once done, include a list in some way or form, of the configurations that we have tested it and agreed that it works properly in.

willend commented 1 month ago

@Lomholy thanks for reporting/documenting this.

Once you have fixed the bugs and decided on the best "test scenarios", I can recommend including %Example lines in the instrument headers (i.e. in ILL_SALSA and Test_Monochromator_bent - then these will ensure tests / reproducibility going forward.