McStasMcXtrace / McCode

The home of the McStas (neutrons) and McXtrace (x-rays) Monte-Carlo ray-tracing instrument simulation codes.
https://github.com/McStasMcXtrace/McCode/wiki
GNU General Public License v3.0
77 stars 54 forks source link

mcgui: run dialogue tickmark for "autoplot" #458

Closed willend closed 7 years ago

willend commented 7 years ago

Should be easy to do:

Add a tickmark option to get

mcrun simulation.instr --autoplot

(a mcrun python only feature, but let's simply add it to "simulation" runs)

climbcat commented 7 years ago

The --autoplot flas has been added to the runstring from mcgui, but it does not work. The string produces an autoplot when executed in the terminal.

We could change the way mcrun calls its plotter subprocess (it should wait for its child process to terminate), or reimplement --autoplot in mcgui. If we use the former, the mcgui UI will behave as though a simulation is running while the plotting window is open. I suppose the latter option would be cleaner, but slightly tricky to implement.

willend commented 7 years ago

Will have a look later myself 😊

Get Outlook for iOShttps://aka.ms/o0ukef


From: Jakob Garde notifications@github.com<mailto:notifications@github.com> Sent: torsdag, maj 4, 2017 4:00 PM Subject: Re: [McStasMcXtrace/McCode] mcgui: run dialogue tickmark for "autoplot" (#458) To: McStasMcXtrace/McCode mccode@noreply.github.com<mailto:mccode@noreply.github.com> Cc: Peter Kjær Willendrup pkwi@fysik.dtu.dk<mailto:pkwi@fysik.dtu.dk>, Author author@noreply.github.com<mailto:author@noreply.github.com>

The --autoplot flas has been added to the runstring from mcgui, but it does not work. The string produces an autoplot when executed in the terminal.

We could change the way mcrun calls its plotter subprocess (it should wait for its child process to terminate), or reimplement --autoplot in mcgui.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/McStasMcXtrace/McCode/issues/458#issuecomment-299193459, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIMfyxdNPlLOg3wdg561BXiBSEhHVCzXks5r2dnwgaJpZM4NQgtG.

willend commented 7 years ago

Did you do anything more to this @climbcat - it works nicely here (in a fresh ./build_macos...)

willend commented 7 years ago

Could you maybe "gray out" the tickmark if Trace is used?

willend commented 7 years ago

Also works fine on Ubuntu here. One detail that I'll have a look at is "backgrounding" the mcplot call from mcrun - otherwise the mcrun looks "busy" still from the POV of mcgui.

willend commented 7 years ago

... and also works on Windows 10

willend commented 7 years ago

Closing, works just fine :-)

climbcat commented 7 years ago

Ok :) And yes will gray out if trace