McStasMcXtrace / mccode-antlr

McCode grammar implemented with ANTLR4
1 stars 0 forks source link

Possible invalid C multiline comment #47

Closed g5t closed 5 months ago

g5t commented 5 months ago

https://github.com/McStasMcXtrace/mccode-antlr/blob/132fb4fa1733f614d190b6bf856548be5293aa2d/mccode_antlr/translators/c_initialise.py#L43

If the string representation of a component Instance contains the characters */ this multiline comment will break, and the resulting C file will not compile.

Either remove this line entirely, or only include the 'basic' positioning/orienting part of the instance definition. // COMPONENT instance = Type() AT (x, y, z) RELATIVE rel ROTATED (a, b, c) RELATIVE rel without any GROUP, JUMP, EXTEND, METADATA, etc., information following.

g5t commented 5 months ago

Fixed by #49