search

Mccranky83 / everforest-browser-theme

An Everforest theme for Chromium & Firefox
1 stars 0 forks source link

Ask for a themed right button menu #1

Open fish4terrisa-MSDSM opened 2 months ago

fish4terrisa-MSDSM commented 2 months ago

I had a try for yout browser theme on chrome. That's really what I'm looking for! Thank you for your great work:-) And...It seems that the right button menu isn't themed as expected, will you add it? After all, it's a great theme, i think.

fish4terrisa-MSDSM commented 2 months ago

And, It seems that all the menus and configuration pages aren't themed...

Mccranky83 commented 2 months ago

Glad you liked the theme! Everforest really is the best, isn't it? @fish4terrisa-MSDSM

I'll assume that by "right button menu" and "configuration pages", you mean the popup menu that appears when you press the right mouse button and chrome's settings page. The right button menu seems to be one and the same as the OS's default, which would require turning off SIP on Mac. To be honest, I never riced that deep and don't really know how.

I used this as reference when I wrote this theme, but I don't think it introduced any properties concerning the settings page. It mainly focuses on the new tab page (ntp).

Sorry if this isn't much help. I'll look up on how to make it work as soon as I can!

fish4terrisa-MSDSM commented 2 months ago

Glad you liked the theme! Everforest really is the best, isn't it? @fish4terrisa-MSDSM

I'll assume that by "right button menu" and "configuration pages", you mean the popup menu that appears when you press the right mouse button and chrome's settings page. The right button menu seems to be one and the same as the OS's default, which would require turning off SIP on Mac. To be honest, I never riced that deep and don't really know how.

I used this as reference when I wrote this theme, but I don't think it introduced any properties concerning the settings page. It mainly focuses on the new tab page (ntp).

Sorry if this isn't much help. I'll look up on how to make it work as soon as I can!

I uses linux, and the chromium default theme(which only changed the color) can change the popup menu's theme and doesn't follow the gtk theme, so I think there seems to exist a way to change the popup menu, especially in linux. And, yes, Everforest is the best! I uses the Everforest gtk theme on my archlinux, with some minor fixes made by myself. The chromium is always a bit strange when it tries to follow the gtk(system) theme...and your theme made it look really GREAT! Looking forward for your fixes! XD

Mccranky83 commented 2 weeks ago

Sorry for the late response. Got around with a bit of digging, and here's what I found:

The official API documentation only covers how to add items to the context menu, but not a word about anything else.

Presumably, the context menu appearance is controlled by the OS or the browser, not the extension. So I guess we'd either have to create a fork of the browser and hard-code the theme into it, or create a new theme at OS level, both are beyond me.

Or, I can choke the og menu and create a custom one, but then we won't be able to use any of its original features.

document.addEventListener("contextmenu", function (e) {
  e.preventDefault();
  ...
});

@fish4terrisa-MSDSM