Mclilzee / zap-simulator

Zap Matrix Simulator
https://mclilzee.github.io/zap-simulator/
Other
4 stars 16 forks source link

Final touches #21

Closed DigitalKnight0 closed 2 years ago

DigitalKnight0 commented 2 years ago

Just leaving a list of stuff here that needs to be done so someone can pick them up and contribute if they want

BlizZard-bot commented 2 years ago

I could take care of a couple of these though I was wondering if making these into separate issues would be better

DigitalKnight0 commented 2 years ago

@BlizZard-bot thank you! Yes i do agree that seperate issues would be better. Please feel free to create them for whichever tasks you are working on!

ManonLef commented 2 years ago

I like what you did to the buttons in the dropdown! I did make a few quick adjustments in the devtools and think they may be a bit more in line with the rest of the design with a few minor adjustments.

I'm not entirely sure I can fix this myself but if you like this screenshot, I could give it a try?

changes:

Let me know what you think!

My adjustments: Screenshot 2022-02-17 at 10 06 12

versus Current live version: Screenshot 2022-02-17 at 10 10 28

BlizZard-bot commented 2 years ago

@DigitalKnight0 Regarding 4, do you want the theme to switch when the container for the SVG is clicked or not? Isn't really clear from the description

DigitalKnight0 commented 2 years ago

@BlizZard-bot made a issue over at #29 with the details

DigitalKnight0 commented 2 years ago

@ManonLef I had one more solution regarding the buttons that might work. The current design looks good indeed, but it falls out with the rest of the page design. I will create an issue with the design i have in mind and let you know!