search

Mclilzee / zap-simulator

Zap Matrix Simulator
https://mclilzee.github.io/zap-simulator/
Other
4 stars 16 forks source link

Variable names not descriptive in js file. #25

Closed JJJ4032002 closed 2 years ago

JJJ4032002 commented 2 years ago

There are several variables such as _ind , o_tier , ctier which are not descriptive enough. I think they should be change to something like _FormBtnNum, offence_tier , afterOffencetier. They are long but are descriptive enough. If enough people approves this than i can make changes.

Mclilzee commented 2 years ago

Go for it, uncle bob's boy scouts rule

BlizZard-bot commented 2 years ago

@JJJ4032002 you working on this?

JJJ4032002 commented 2 years ago

@BlizZard-bot sorry for the late response. I am a little busy with some other stuff right now. So you can take it up if you want.

BlizZard-bot commented 2 years ago

I don't know what the variables are for so I don't think I'll be able to do it. This is probably something that @Mclilzee or @DigitalKnight0 could take up

JJJ4032002 commented 2 years ago

Its ok i will look into it later.

BlizZard-bot commented 2 years ago

@JJJ4032002 is there any update on this?

mgrigoriev8109 commented 2 years ago

@LeoKirasic I can pick this up.

robocopyZer0 commented 2 years ago

@mgrigoriev8109 All yours!

JJJ4032002 commented 2 years ago

@mgrigoriev8109 thanks for taking it up though I have changed some variable names where I found suitable and created a pull request. If you want you can see my changes too and see if it can be better.

robocopyZer0 commented 2 years ago

This has been addressed in a PR, closing.