Closed JJJ4032002 closed 2 years ago
Go for it, uncle bob's boy scouts rule
@JJJ4032002 you working on this?
@BlizZard-bot sorry for the late response. I am a little busy with some other stuff right now. So you can take it up if you want.
I don't know what the variables are for so I don't think I'll be able to do it. This is probably something that @Mclilzee or @DigitalKnight0 could take up
Its ok i will look into it later.
@JJJ4032002 is there any update on this?
@LeoKirasic I can pick this up.
@mgrigoriev8109 All yours!
@mgrigoriev8109 thanks for taking it up though I have changed some variable names where I found suitable and created a pull request. If you want you can see my changes too and see if it can be better.
This has been addressed in a PR, closing.
There are several variables such as _ind , o_tier , ctier which are not descriptive enough. I think they should be change to something like _FormBtnNum, offence_tier , afterOffencetier. They are long but are descriptive enough. If enough people approves this than i can make changes.