Fix: change wording of the zaps

Mclilzee / zap-simulator

Zap Matrix Simulator

https://mclilzee.github.io/zap-simulator/

Other

4 stars 16 forks source link

Fix: change wording of the zaps #44

Closed scheals closed 2 years ago

scheals commented 2 years ago

Changes:

I have changed the wording of particular zap descriptions:

Opted for present continuous
Made button order match the list order in the matrix
Made wording resemble matrix wording whenever possible
Typo and other various fixes

Mclilzee said:

I don't think we need it to be verbose, but make it more clear. For example, there are Self promotion under spam offense, one guarantees a ban and another only gives you 2 zaps. Knowing the differentiation between them is important.

Issues like this I think are more about how Matrix is worded currently - the problem with self promotion being twice in the rules with different punishments while not having exclusive conditions is somewhat confusing. I believe that there's an implicit understanding that the 2 zap version of self promotion is about people who are doing TOP, while the 10 zap version of self promotion is about people who come from outside and just leave the message to see whether it sticks.

I must say that rewording the mental health zap is pretty hard since communicating the "in depth" or "seeking help" part in a laconic way seems impossible. Need feedback on this for sure.

Closes #32

BlizZard-bot commented 2 years ago

Since you asked for opinions @scheals, I'll give you mine. I believe overall it looks pretty good but I have a few suggestions:

"Suggesting piracy" could be changed to "Discussing topics related to piracy" or similar. This is because people may not suggest piracy but discuss things amounting to piracy
The contents of <button class="t4 i1"> and <button class="t4 i2"> seem to have been interchanged. Don't know how the code around those is structured but this could potentially be a problem. Same for <button class="t4 i3"> and <button class="t4 i4">

Other than that, it looks pretty good to me. I agree that the mental health offense seems difficult to frame, especially within a few words

scheals commented 2 years ago

"Suggesting piracy" could be changed to "Discussing topics related to piracy" or similar. This is because people may not suggest piracy but discuss things amounting to piracy

This is probably a good idea. I'm going to change it.

The contents of <button class="t4 i1"> and <button class="t4 i2"> seem to have been interchanged. Don't know how the code around those is structured but this could potentially be a problem. Same for <button class="t4 i3"> and <button class="t4 i4">

From what I can see, nothing has happened due to this. Good on you noting this, I absent-mindedly just swapped them without thinking whether those classes are super important.

Other than that, it looks pretty good to me. I agree that the mental health offense seems difficult to frame, especially within a few words

Thank you for your feedback, @BlizZard-bot!

Mclilzee commented 2 years ago

@scheals is this ready to be merged or you working on it further?

scheals commented 2 years ago

@scheals is this ready to be merged or you working on it further?

@Mclilzee Should be ready now!