search

Mclilzee / zap-simulator

Zap Matrix Simulator
https://mclilzee.github.io/zap-simulator/
Other
4 stars 16 forks source link

Tier 10 zaps generate tier moved text #45

Open scheals opened 2 years ago

scheals commented 2 years ago

Tier 10 zaps, both those that "grew" to be ones and those that start out us such still generate the "tier moved" message which makes them display 10 => undefined. Probably best idea to just get rid of this message when a tier 10 zap is applied.

Mclilzee commented 2 years ago

@scheals would you like to work on this?

scheals commented 2 years ago

@Mclilzee I have a very hard time navigating the codebase, to be frank. Think we should put this off until we get to refactoring so the bug doesn't stay after it.

takinabradley commented 2 years ago

With the JS refactor, the behavior of this is a little different now. The text now displays '10 => 10`.

If we prefer a custom message for the 'max' tier level, or no move message at all a change could be made.

BlizZard-bot commented 2 years ago

Does the current behavior really need to be changed? When a 10 zap offense happens, the "you just got banned" screen gets displayed which cannot be removed unless you click on the button

takinabradley commented 2 years ago

@BlizZard-bot @LeoKirasic I don't think so. I think this issue is probably safe to close, unless someone has another opinion.

Depending on the browser you use, the message can be seen clearly though.

BlizZard-bot commented 2 years ago

@takinabradley Ah okay I see it now, backdrop-filter isn't supported on FireFox so it won't work on that