Mcpxndx / slideshow

Automatically exported from code.google.com/p/slideshow
0 stars 0 forks source link

Thumbnails don't display in some circumstances #112

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Visit http://www.charlottechapel.org/arr/cmsms/

What is the expected output? What do you see instead?
Expected - Thumbnails should display below the main image (see source -
"thumbnails: true").
Actual - No thumbnails displayed (more below).

What version of the product are you using? On what operating system and
browser?

Windows XP.  Tried Firefox 3.5 and IE8 with identical results.

Please provide any additional information below.

Using Firebug, it's clear that...

1. slideshow is attempting to show thumbnails (The "Net" tab shows the
thumb_* files being fetched).  (When "slideshow: false" is set, this
doesn't happen.)
2. The thumbnails are successfully fetched from the webserver.  Firebug is
able to display them.
3. The slideshow-thumbnails <div> is in the correct place (below the main
image).
4. The underlying <ul> is correct (extending beyond the parent <div> and
sliding to the left as show plays).
5. The <li>'s that contain the thumbnails are present, as are the child
<a>'s and finally the <img>'s.
6. The <img>'s contain the correct images (& Firebug is able to display them).
7. There's nothing obvious (at least to me) in any of the styles that
should prevent the images from displaying - but they don't.

I've tried modifying all sorts of styles in an attempt to make the images
visible, but all to no effect.

Original issue reported on code.google.com by andrewr...@gmail.com on 26 Aug 2009 at 8:48

GoogleCodeExporter commented 8 years ago
Sorry, I failed to mention that I'm using Slideshow2r147.

Original comment by andrewr...@gmail.com on 26 Aug 2009 at 8:53

GoogleCodeExporter commented 8 years ago
Your .slideshow wrapper has an overflow: hidden. The .slideshow-thumbnails 
extend
below the boundry of the wrapper. Hence thumbnails do not appear.

You can either remove the overflow: hidden or increase the vertical height of 
the
wrapper.

Original comment by aeron.gl...@gmail.com on 26 Aug 2009 at 9:56

GoogleCodeExporter commented 8 years ago
Many thanks - that has solved my problem.

Although it doesn't affect me now, you might consider...

1. Ensuring that the thumbnail <div> causes the parent to grow appropriately (by
putting it 2nd in the source?).

2. I also noticed that the main images were offset slightly to the right (now
corrected).  This was because of a general CSS style I had for <img>'s.  
However, in
general, your CSS is usually very careful to explicitly set all the relevant 
values
for .slideshow-* elements.  I wonder if it's worth you adding 
".slideshow-thumbnails
a img {margin: 0}" to the default CSS.  (It doesn't really bother me either way,
because I've got a perfectly good workaround, but it might help future users.)

Once again, many thanks for your assistance.

Andrew

Original comment by andrewr...@gmail.com on 26 Aug 2009 at 10:45

GoogleCodeExporter commented 8 years ago
Thank you for the comments. In general I find the more things I take control 
over the
more bloated the script becomes and the less options are available without 
hackery
(using !important to overrule JS styles, etc). Slideshow was always intended 
for an
audience that was familiar with CSS and JS. The easier I make the script to just
"plugin and use" the more time I end up having to devote to supporting the user 
base.

Original comment by aeron.gl...@gmail.com on 26 Aug 2009 at 11:02

GoogleCodeExporter commented 8 years ago
I fully understand!

All the best.

Andrew

Original comment by andrewr...@gmail.com on 27 Aug 2009 at 7:27