search

MeanEYE / Sunflower

Small and highly customizable twin-panel file manager for Linux with support for plugins.
GNU General Public License v3.0
428 stars 42 forks source link

Pressing enter from quick search containing ".." does not change current directory. #288

Open MAWSpitau opened 6 years ago

MAWSpitau commented 6 years ago

Hi there,

I like to walk trough my dirs with the keyboard. Searching for dirs and file with just typing in the thing I want works pretty cool, but to go to a parent dir by just typing ".."+ enter does not work.

After typing .. nothing happens :( That makes my sad ;)

I would prefer the ".." would be handled like a normal path.

Thanks for sunflower!

MAW

MeanEYE commented 6 years ago

Can you give me more information about what happens. By typing .. are you invoking quick search, or entering a command?

MeanEYE commented 6 years ago

And you are welcome! :)

MAWSpitau commented 6 years ago

I sent a mail as a reply, but it seems it will not get here ;)

So:

it opens the Searchbox at the end. But it will not go into the parent dir... For better understanding, there is a little Screencast.

https://www.dropbox.com/s/1204a1m3em3s9te/sunflowerProblem.mkv?dl=0

Thanks a lot Marcel

MeanEYE commented 6 years ago

Oooh, that's a strange one. It should absolutely do that. Thanks for reporting it. I'll fix it!

joshas commented 4 years ago

There's a check that prevents going up to parent directory if quick search is active: https://github.com/MeanEYE/Sunflower/blob/6b4aef4fca2506912f1f14ec4a7e8e68f49b42ae/sunflower/plugin_base/item_list.py#L1236-L1239

I guess this was included to prevent going up directories when pressing Backspace key.

MeanEYE commented 4 years ago

Hm, right you are. This check is there so Backspace could work. But it's preventing the regular move to parent directory as well. Good catch @joshas.