Closed joshas closed 3 years ago
_prepare_icons() function sets fallback icons for file and directory using deprecated constants: Gtk.STOCK_FILE and Gtk.STOCK_DIRECTORY . According to GTK+ 3 docs they should be replaced by named icons: "text-x-generic" and "folder". https://github.com/MeanEYE/Sunflower/blob/6b4ad8db726764ce0153b5a45e3ca59d0eb68367/sunflower/icons.py#L25-L34
_prepare_icons()
After replacing both icon constants has_icon() check becomes redundant, at least in "folder" case. Could this function be refactored by setting default icon names to "text-x-generic" and "folder", and removing has_icon() check and fallbacks?
has_icon()
_prepare_icons()function sets fallback icons for file and directory using deprecated constants: Gtk.STOCK_FILE and Gtk.STOCK_DIRECTORY . According to GTK+ 3 docs they should be replaced by named icons: "text-x-generic" and "folder". https://github.com/MeanEYE/Sunflower/blob/6b4ad8db726764ce0153b5a45e3ca59d0eb68367/sunflower/icons.py#L25-L34After replacing both icon constants
has_icon()check becomes redundant, at least in "folder" case. Could this function be refactored by setting default icon names to "text-x-generic" and "folder", and removinghas_icon()check and fallbacks?