MeanEYE / Sunflower

Small and highly customizable twin-panel file manager for Linux with support for plugins.
GNU General Public License v3.0
430 stars 42 forks source link

Missing Title Bar #495

Open DadTheTester opened 3 years ago

DadTheTester commented 3 years ago

After not using Sunflower for a few years, I decided to try it again. An interesting thing happened that I wished to report to you.

If the user selects the gear icon and then View and then unchecks Show titlebar, all is lost. There is no way to close it or get that preference icon back. The only solution is the close the program from the right-click on the task bar and then delete the config.jason file before restarting it again.

It appears that the use of the title bar in place of a menu bar is the problem. While I thought I might like the idea of using real estate that is under utilized, it is a bad idea if it cannot be partitioned appropriately.

I am using Debian 10 with Xfce 4.12.

Hope you can fix it. Thanks for your efforts.

vfaronov commented 3 years ago

and then delete the config.jason file before restarting it again

You don’t need to delete the entire file, just the line containing "show_titlebar": false.

DadTheTester commented 3 years ago

FYI, it is far easier to delete the file and let it be automatically created again than it is to open an editor and go to all the trouble of finding and editing one line. Of have I missed something else?

MeanEYE commented 3 years ago

Hi and thanks for reporting this. Title bar is not required for proper operation and some people who use tiling window managers have asked for this feature. But I do agree current solution is not the best one. We could move main menu and other controls to overlay if the title bar is hidden and teach people how to access it. This would make the transition smoother and also provide nice functionality when application is put to full screen.

I will accept this issue and see if I can come up with good visual solution in next few releases.

vfaronov commented 3 years ago

FYI, it is far easier to delete the file and let it be automatically created again than it is to open an editor and go to all the trouble of finding and editing one line. Of have I missed something else?

It’s just that by deleting the file you lose all the other settings, too.

ncmprhnsbl commented 3 years ago

another way present to regain the title bar is: keybind: ctl+alt+p which opens preferences> tick 'show titlebar' .. a keybind that simply toggles the titlebar (and possibly ones that toggle toolbar and command bar) might be nice. and "We could move main menu and other controls to overlay if the title bar is hidden" is a better solution imo.