Closed shabaev closed 3 months ago
Thanks for putting this together!
I went ahead and merged the checkbox logic in this commit: https://github.com/MeanderingProgrammer/markdown.nvim/commit/90637a1120de47a3be57b00b7db4eee0d24834c8, largely copied from this PR.
Sorry to not just merge this PR as is, looks like you were in the process of making the final changes.
There were some modifications I made that I'll call out here:
state.lua
Config class should be mandatory, the UserConfig makes everything optional but the actual Config should have a reasonable default for everything, including sub classes. This was probably just a copy pasta thing that left in the ?
in a few places.(paragraph)
addition to the list_marker query, was also unsure about the reason for that, LMK if there was one.ui.lua
to reduce some of the duplication and handle different padding / character widths.Some of these I might make more general and add to a contributing guide if there are more contributions, but I think it's getting to a fairly stable point.
Most are just my nit picky preferences.
I'll close out this PR since all the proposed changes are merged.
Feel free to shoot me any ideas or create more PRs more than happy to look over them.
Thanks again!
gday,
Sorry to not just merge this PR as is, looks like you were in the process of making the final changes.
nvm, it was a workable draft I were able and wanted to share with you to discuss and to pick some code. the goal achieved. thank you.
Everything in the state.lua Config class should be mandatory,
yup. I overlooked that. thanks for watching my back :100:
included the listmarker* prefix
the idea was to remove list bullets if it's a task list, but I agree with your point of view.
to reduce some of the duplication
it looks perfect. thank you for the optimization (and to show me personally how to) :+1: