MeanderingProgrammer / markdown.nvim

Plugin to improve viewing Markdown files in Neovim
MIT License
504 stars 20 forks source link

Problems with ordered lists and config defaults #7

Closed bertradio closed 3 months ago

bertradio commented 3 months ago

I really love the approach of this plugin.

But it seems to have a problem with display of ordered lists. Unless they are indented a couple of times they don't display with the numbers, only the icons and a "."

So I tried using the full setup config from the help file. That completely crashed the plugin and I had to remove it. Is there an updated version?

Thanks for the great work!

MeanderingProgrammer commented 3 months ago

Thanks for bringing these problems up!

For the latter problem of the config this was due to me using vim.tbl_deep_extend when combining the default config and the user config, which ended up removing the metatable of the query object when a user config is provided.

I updated the configuration to accept a string instead and to do the parsing of the query in the plugin itself: https://github.com/MeanderingProgrammer/markdown.nvim/commit/70f8f4f64d529d60730d6462af180bbec6f7ef18.

So now providing the full configuration as in the README should work.

I hadn't thought of ordered lists, haha, you're right, this does not work for them. Still working on fixing this problem.

MeanderingProgrammer commented 3 months ago

Ordered lists should no longer use the bullet point after this change: https://github.com/MeanderingProgrammer/markdown.nvim/commit/f5917d2113ce2b0ce8ce5b24cfbd7f45e0ec5e67

Thanks for reaching out and feel free to re-open if there is still a problem!

bertradio commented 3 months ago

Thanks.

On Fri, Mar 22, 2024, at 18:43, Vlad wrote:

Ordered lists should no longer use the bullet point after this change:f5917d2

Thanks for reaching out and feel free to re-open if there is still a problem!

— Reply to this email directly, view it on GitHub https://github.com/MeanderingProgrammer/markdown.nvim/issues/7#issuecomment-2016292316, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLYYRPMDCAL6LFCXWGB2XTYZTM4TAVCNFSM6AAAAABFEDGGFKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGI4TEMZRGY. You are receiving this because you authored the thread.Message ID: @.***>