MeanderingProgrammer / render-markdown.nvim

Plugin to improve viewing Markdown files in Neovim
MIT License
1.6k stars 37 forks source link

bug: conceallevel isn't togglable when render-markdown is toggled off #208

Closed fpohtmeh closed 16 hours ago

fpohtmeh commented 20 hours ago

Neovim version (nvim -v)

0.10.1

Neovim distribution

LazyVim

Operating system

Windows 11

Terminal emulator / GUI

WezTerm

Describe the bug

LazyVim provides shortcuts to toggle render-markdown and conceal level. Due to plugin configuration, it's not possible to have a toggleable conceal level for disabled render-markdown.

I always have 3 as the conceal level for any state of render-markdown

Expected behavior

Conceal level changes from 3 to 0 and back for disabled render-markdown

Healthcheck output

==============================================================================
render-markdown: require("render-markdown.health").check()

render-markdown.nvim [version] ~
- OK plugin 7.3.11
- OK neovim >= 0.10

render-markdown.nvim [configuration] ~
- OK valid

render-markdown.nvim [nvim-treesitter] ~
- OK installed
- OK markdown: parser installed
- OK markdown: highlight enabled
- OK markdown_inline: parser installed
- OK markdown_inline: highlight enabled
- WARNING latex: parser not installed
  - ADVICE:
    - Disable LaTeX support to avoid this warning by setting { latex = { enabled = false } }

render-markdown.nvim [executables] ~
- WARNING latex2text: not installed
  - ADVICE:
    - Disable LaTeX support to avoid this warning by setting { latex = { enabled = false } }

render-markdown.nvim [conflicts] ~
- OK headlines: not installed
- OK obsidian: not installed

Plugin configuration

Default LazyVim configuration

Plugin error log

Log is empty

Confirmations

Additional information

No response

MeanderingProgrammer commented 19 hours ago

If I'm not understanding something let me know. But based on your wording are you saying that when this plugin is disabled you still expect it to modify the conceallevel on mode changes? Or are you saying that you can't manually change the conceallevel and this plugin locks it to 3 when it's disabled?

fpohtmeh commented 19 hours ago

Brief steps to reproduce:

MeanderingProgrammer commented 16 hours ago

Ah, thanks, was able to reproduce this. Should be fixed by: https://github.com/MeanderingProgrammer/render-markdown.nvim/commit/bea6f2078e34abdf5c2632f593651bb13205477f.

fpohtmeh commented 16 hours ago

Thank you a lot, man! ⚡