Closed alexcombessie closed 4 years ago
@bgalego thanks! I have added your suggested changes. Let me know if you have any additional suggestions!
That's great @alexcombessie! I'm half-way through the review (I'm also updating our documentation at the same time), but everything looks great!
Hi @bgalego! Thanks for the time spent this week to refine this PR. If the plugin doc is ready, do you think we can publish next week? Cheers, Alex
I think so! I'll do a quick once-over on Monday, but I think everything will be fine. I also was thinking of increasing the version number to 1.0.1, but I haven't checked yet if it makes sense directly in the PR, or right after when I release a new version in the master branch.
I'll get back to you on Monday. Thanks for all the hard work!
Hi @bgalego,
Please find my pull request ready for review. All in all the plugin was working well, so I have not changed the logic of the code but focused on refining the UX.
Here is a summary of the main changes.
Sentiment analysis: added subjectivity, irony, agreement and confidence scores
If that's OK with you, we can publish this new version to the Dataiku plugin store.
For future versions, I have noted a few ideas for enhancement you could look into:
CustomAPIFormatter
classes for each API endpoint to turn your JSON response into nicely formatted new columns, similarly to SentimentAnalysisAPIFormatterThanks again for the good work and drive to make this plugin available to Dataiku users.
Best regards,
Alex