Pull requests into Health Data Standards require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:
[x] This pull request describes why these changes were made.
[x] This PR is into the correct branch.
[x] ~Internal ticket for this PR:~
[x] ~Internal ticket links back to this PR~
[x] Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
[x] ~Tests are included and test edge cases~
[x] Tests have been run locally and pass
[x] Code coverage has not gone down and all code touched or added is covered.
In rare situations, this may not be possible or applicable to a PR. In those situations:
Note why this could not be done or is not applicable here:
Add TODOs in the code noting that it requires a test
Add a JIRA task to add the test and link it here:
Cypress Reviewer:
Name: @dczulada
[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code
Bonnie Reviewer:
Name: @losborne
[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
Pull requests into Health Data Standards require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable ("N/A") and :white_check_mark:.
Submitter:
Cypress Reviewer:
Name: @dczulada
Bonnie Reviewer:
Name: @losborne