MeasuringPolyphony / mp_editor

https://editor.measuringpolyphony.org
4 stars 2 forks source link

Dissonance labels are not displayed #116

Open martha-thomae opened 10 months ago

martha-thomae commented 10 months ago

Dissonance labels are not displayed in the Score Editor anymore. I tried with one of the files (for which everything was working fine before), and no dissonance labels are displayed anymore. This is a screenshot of what I get when moving to the score editor and then clicking on the checkbox to "Add dissonance labels."

Screenshot 2023-08-14 at 18 08 09

If you want to replicate the issue, you can use the following file, scroll to folio 73v, click on one of the systems, and then click on the button to move to the score editor. Once in the score editor, click on the "Add dissonance labels" checkbox.

Missa10.2_Gloria_Section1_f73v-74r_MENSURAL_PARTS.xml.zip

Help @craigsapp and @JRegimbal! Thank you! I would like to show this nice functionality we added to the score editor during the MEC/TEI conference happening this Sept. 03. Thanks :)

JRegimbal commented 10 months ago

Hi Martha, sorry for the delay in looking at this! It looks like something is happening in verovio-toolkit-wasm.js when calling dissonanceInfo. I'm including the console lines here:

Error: Inconsistent rhythm analysis occurring near line 162 verovio-toolkit-wasm.js:14:11229995
Expected durationFromStart to be: 239 but found it to be 240 verovio-toolkit-wasm.js:14:11229995
Line: *-    *-  *-  *-  *-  *-  *-  *-  *-  *-  *-  *- verovio-toolkit-wasm.js:14:11229995
<empty string> verovio-toolkit-wasm.js:14:11229995

No dissonance information is being returned from the function. Do you know if this is working for other files?