MeasuringPolyphony / mp_editor

https://editor.measuringpolyphony.org
4 stars 2 forks source link

Dots after Rests #52

Open DanielS146 opened 4 years ago

DanielS146 commented 4 years ago

In Music Input and Score Editor, dots cannot be placed after a rest.

martha-thomae commented 4 years ago

I am under the impression that Verovio is still not rendering dots after rests, but I don't know if this could be related to this issue. Could this be the case, @JRegimbal ?

JRegimbal commented 4 years ago

Sorry for the delay. It's easy to allow dots to be added to rests and by default it is converted to MEI as dots=1 added to the rest element. @martha-thomae is correct that Verovio does not render this, so I'm unsure if allowing essentially invisible dots would be more trouble than its worth.

JRegimbal commented 4 years ago

(Also looking at the VHV using the separate dot element doesn't make a difference in anything being rendered.)

martha-thomae commented 4 years ago

(Also looking at the VHV using the separate dot element doesn't make a difference in anything being rendered.)

It probably doesn't. But in Mensural MEI the "right way" to encode a dot is with a separate element, and not as an attribute (which is what you would do in CMN). What happens if you remove the attribute and leave the element, does it stops rendering dots altogether?

martha-thomae commented 4 years ago

Sorry for the delay. It's easy to allow dots to be added to rests and by default it is converted to MEI as dots=1 added to the rest element. @martha-thomae is correct that Verovio does not render this, so I'm unsure if allowing essentially invisible dots would be more trouble than its worth.

I haven't tried this (using @dots in <rest>).

I know it didn't render

<rest/>
<dot/>

I don't know if it does now.

JRegimbal commented 4 years ago

Checking now, it sort of does? It doesn't show up right reading from humdrum (i.e., in the input editor) but it does appear with the position very off when reading from MEI where dot after rest can be specified. However it seems to just end up getting placed closer to a preceding note element rather than after the rest itself.

martha-thomae commented 4 years ago

Yes, that last part sounds familiar. I think I had this issue before (Verovio rendering the dot of the rest on the preceding / following note).

karend27 commented 4 years ago

So I'm looking at an ars antiqua piece we encoded for the Measuring Polyphony project that has dots after rests - screenshot here and mensural mei file attached. The dot is placed here where it should be: right after the rest. The dots are encoded as separate elements not as attributes. You'll see here there are both notes and rests that have dots following them and each time the dots are encoded as elements.

Screen Shot 2020-09-04 at 10 22 36 AM

Look in the code for the rest with "xml:id="m-896" for the first of these rests with a dot after it. 332_MENSURAL.mei.zip

martha-thomae commented 4 years ago

Hmmm, you are right, they are rendering correctly. Let me check, I am pretty sure I was working with larger note values. Will check if there is any difference.

martha-thomae commented 4 years ago

Yes, it seems to be rendered in the right place for smaller values of rests than larger. Here is an MEI file and the screenshot of its rendition in Verovio. The dots are encoded always after the rest in the MEI file, but they are rendered before them in Verovio for larger note values.

notes_rests_dots.mei.zip

Verovio-rendering

karend27 commented 4 years ago

Will I raise this as an issue in the Verovio github?

martha-thomae commented 3 years ago

Yes, I think that might be best. Please feel free to use any of the files and images I attached :)

karend27 commented 3 years ago

Ok - I opened a new issue here: https://github.com/rism-ch/verovio/issues/1682