search

MeasuringPolyphony / mp_editor

https://editor.measuringpolyphony.org
4 stars 2 forks source link

Coloration #82

Closed martha-thomae closed 3 years ago

martha-thomae commented 3 years ago

This pull request implements coloration by including the keystrokes to enter colored notes, which are translated into their corresponding tokens in **mens (recently included into Humdrum).

karend27 commented 3 years ago

Hi @martha-thomae - was wondering if coloration has been merged in?

martha-thomae commented 3 years ago

Hi @karend27! Thanks for the reminder, not yet. @JRegimbal, would you mind merging this PR if you agree with the changes? thanks!

JRegimbal commented 3 years ago

Oops sorry I didn't realize this was waiting on me. It seems good from my end!

martha-thomae commented 3 years ago

Perfect, thank you! Can you merge, @JRegimbal ? I don't seem to have permissions for this.

JRegimbal commented 3 years ago

Oh I manually added it in already. I don't know why it isn't marked...let me try again to see if I can make github happy.

martha-thomae commented 3 years ago

Thanks! :)