search

Meazer / hyf-javascript1

Homework JavaScript 1
0 stars 0 forks source link

Feedback homework week 2 #1

Open remarcmij opened 6 years ago

remarcmij commented 6 years ago

Hi Meazer, here is my feedback on your homework for week 2.

You've done a great job here. Your code works correctly, is nicely formatted and your choice of variable names is excellent.

A couple of minor points.

1-stings.js

1. This file should actually be named strings.js.

2. Be consistent in your use of quotes as string delimiter. Either choose single quotes or double quotes and then stick to that for all of your code (I prefer single quotes myself).

2-arrays.js

3. This file is missing a 'use strict' line.

3-months.js

4. It is best to always use strict equality: use === instead of ==.

4-maartje.js

5. This file is missing a 'use strict' line.

Meazer commented 6 years ago

Hi Jim,

Thank you for your feedback, I have implemented it.