MechMicroMan / DefDAP

A python library for correlating EBSD and HRDIC data
Apache License 2.0
36 stars 18 forks source link

Add optional new DIC grain detection #74

Closed rhysgt closed 4 years ago

rhysgt commented 4 years ago
mikesmic commented 4 years ago

This needs to pass the tests before it can be merged

rhysgt commented 4 years ago

The error seems to be in test_quat.py. I think you have already fixed this in the develop branch.

_____________________ ERROR collecting tests/test_quat.py ______________________
430 ImportError while importing test module '/home/travis/build/MechMicroMan/DefDAP/tests/test_quat.py'.
431 Hint: make sure your test modules/packages have valid Python names.
432 Traceback:
433 ../../../virtualenv/python3.8.0/lib/python3.8/importlib/__init__.py:127: in import_module
434     return _bootstrap._gcd_import(name[level:], package, level)
435 tests/test_quat.py:3: in <module>
436     from pytest_cases import cases_data, CaseData, CaseDataGetter, cases_generator, fixture_plus
437 E   ImportError: cannot import name 'CaseData' from 'pytest_cases' (/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/pytest_cases/__init__.py)

I think the continuous-integration/travis-ci/pr Travis run is the one that is important? It runs the tests on the target branch (ie develop), with this pull request added on?

rhysgt commented 4 years ago

All checks now pass