MechMicroMan / DefDAP

A python library for correlating EBSD and HRDIC data
Apache License 2.0
35 stars 16 forks source link

Recent error with RDR #96

Closed BenP123 closed 1 year ago

BenP123 commented 1 year ago

As discussed briefly earlier, a new error has appeared with using RDR in defDAP.

When I run the grain inspector tool I get

AttributeError: 'FigureCanvasTkAgg' object has no attribute 'set_window_title'

I thought that this might be something with tk, so I swapped to using qt and still get the same error. I'm not sure if this is caused by defdap or some external package as I've tried running this with a clean conda environment with a pip install directly and by cloning the develop branch from github and installing it locally and both still give the same error.

JQFonseca commented 1 year ago

What's the line in DefDap that triggers this? Does the error message say? Could be a bug in Matplotlib, maybe try with a different version to see if it still happens.

rhysgt commented 1 year ago

You could try removing the set_window_title call - all it does it set the name of the window in the title bar! It might be that it's depreciated.

BenP123 commented 1 year ago

It's triggered by dicMap.runGrainInspector()

Thanks for the suggestion Rhys, I'll give that a go.

BenP123 commented 1 year ago

Removing the set_window_title works. RDR seems happy. I'll report back if removing this has broken anything else.

rhysgt commented 1 year ago

Fixed in 718fdad