MechTechnology / SmartStitch

A small program for stitching together webtoons/manhwa/manhua raws.
MIT License
65 stars 26 forks source link

Significantly decreased Memory usage, Proper formatting #14

Closed lvl1scans closed 1 year ago

lvl1scans commented 2 years ago

Massive reduction in Memory usage.

Here is my test result:

Input:

78 images
Dimensions of each image: 690x1600

Output:

Split Height: 10000
Width Enforce Type: 2
Custom Width: 800

Memory Usage Before: 1706 MB Memory Usage After: 475 MB

PS: I have also reformatted the whole file so GitHub shows that whole file is changed.

Aurvandill commented 1 year ago

For a better review of the code changes the actual changes and the reformating should at least be 2 commits or 2 seperate pull requests. If you could do it that way i guess MechTechnology will have an easier time Reviewing it and perhaps merging it

lvl1scans commented 1 year ago

@Aurvandill I’ve already talked with Mech in personal chat. This pull request won’t be merged as Mech has nearly finished working on next version of SmartStitch (see branches). If you want a command line version with my changes, then you may use https://github.com/lvl1scans/SmartStitchLite If you want GUI version with my changes then you may use https://github.com/AbhiMayadam/SmartStitchLiteGUI

With this, I’ll be closing this PR.