search

Mechanical-Advantage / AdvantageScope

Robot telemetry application
MIT License
165 stars 50 forks source link

# not encoded when loading file urls #131

Closed MichaelStatt-S closed 7 months ago

MichaelStatt-S commented 7 months ago

Describe the bug This was discoved when our computer's user folders contained a # to label the computer number. No downloaded assets rendered. Looking at the console, the file wasn't found. This was because the # in the url wasn't replaced with %23

To Reproduce Steps to reproduce the behavior:

  1. create a new custom asset (ex Field3d_2024Field#2
  2. try to render that asset (ex change field to field 2
  3. object doesn't render
  4. file not found error in console
  5. error contains non-encoded #

Expected behavior The objects should render / the # should be encoded

Version (required): image

jwbonner commented 7 months ago

Thanks for reporting this. The update I just pushed appears to fix the issue from my testing. You can download the development builds here if you want to try it before the next release (note that CI only runs AppImage builds for Linux).

MichaelStatt-S commented 7 months ago

Looks good to me! Thanks