Mechanical-Advantage / AdvantageScope

Robot telemetry application
MIT License
165 stars 50 forks source link

Unable to have more than 1 component #137

Closed vichik123 closed 7 months ago

vichik123 commented 7 months ago

My team has 5 components all together this year, and yet even 2 components just crash the app or something because it doesn't load. Using a single component works perfectly. Also, we tried quite a few combinations of components so I don't think the size of the CAD is the problem.

By the way, the app doesn't literally crash. For example if it was on the Kitbot before we switch to our robot it just doesn't switch, and we can even drive the robot around the field with no lag or glitch.

Here is an example of us trying to use the 3d simulation for our 2 stage elevator. Here is a file explaining our components. The first component is the intake so we added that to the elevator config as well.

Are we doing something wrong with the json config? If so, how come AdvantageScope doesn't return an error?

jwbonner commented 7 months ago

It looks like the issue is with the filenames for your component models. Per the documentation, there should be an underscore between "model" and the index, so it would look like "model_0.glb" instead of "model0.glb". The next version will already improve the error handling for invalid JSON configurations (see #134), but I'll add a check for the filenames too so there can be a more useful message displayed.

vichik123 commented 7 months ago

Ah I see, thank you. Although you know, I'm pretty sure it worked for a single component named model0.glb as well.

vichik123 commented 7 months ago

Just not the elevator for some reason.