Medabots / medarot3

Medarot 3 GBC disassembly/translation
34 stars 6 forks source link

Stray pixels for medal graphic #176

Closed Blaziken257 closed 1 year ago

Blaziken257 commented 1 year ago

There are stray pixels present underneath the medal graphic which can be seen on the screen when viewing a Medabot. Comparison screenshots are below — see the medal graphic between the moves and the +8 text:

Japanese English
bgb01082 bgb01083

This is because the in gfx/tilesets/Special.malias.png graphics were shifted upward by one pixel from the Japanese version to the English patch.

Comparison images (and relevant VRAM dumps from BGB) are below:

Japanese English
image
M3_Jpn_BGB_VRAM M3_Eng_BGB_VRAM

The vertical shifting causes part of the "ED" graphic to spill into the medal graphic. The vertical shifting appears to be intentional to better align tiles (such as the cursor ones) with the English font (in contrast with Pokémon R/B/Y, where localized versions have the cursor misaligned because they did not do such a thing). However, the "ED" graphic doesn't appear to even be used at all in the English patch anyway, so perhaps it might be a good idea to nuke it entirely (or make some other graphic in its place if it is appropriate for the English patch).