search

Medabots / medarot3

Medarot 3 GBC disassembly/translation
27 stars 6 forks source link

Italic text wrapping issue #225

Closed Blaziken257 closed 6 months ago

Blaziken257 commented 6 months ago

Summary

There is at least one italic text string (with a dialogue with Viridiana) that has wrapping issues: an exclamation mark wraps around and spans two lines.

The original text (according to the spreadsheet in Section 20 on line 114) says this:

Heeey, heeey. Over here, meow!

A save is attached to this issue (as a ZIP file).

To test this easily (once this is fixed -- might be necessary if the custom text preview doesn't catch this bug):

  1. Use the debug mode (set C480-C481 to 31 00, then select the text debug (14th option from the top).
  2. Set BANK (C742) to 0B.
  3. Set NOH (C473) to 00.
  4. Set NOL (C474) to 73, then press A.

M3 Italic Issue 1 Medarot 3 - Kabuto Version (Japan) (EN 20240114).zip

VariantXYZ commented 6 months ago

<@RL,Viridiana,01>Heeey, heeey. Over here, meow! https://andwhyisit.bugsiteguardian.com/msgbox/medarot3/?t=%3C%40RL%2CViridiana%2C01%3EHeeey%2C%20heeey.%20Over%20here%2C%20%3Cf08%3Emeow%21%3Cf00%3E

Untitled

from the previewer

VariantXYZ commented 6 months ago

I changed the line manually for now anyway, but it looks like the issue is that the italic (and possibly the other fonts) need to have their pixels recounted. Italic '!' and 'i' and some other letters are off by one pixel on their actual width.

VariantXYZ commented 6 months ago

@andwhyisit pointed out that it's actually just due to the way italics font work and how our auto-wrapping doesn't take into account that the italic font is designed to bleed into the normally 'ignored' spacing.

VariantXYZ commented 6 months ago

Fixed by #226