Medabots / medarot3

Medarot 3 GBC disassembly/translation
34 stars 6 forks source link

Long part descriptions -- particularly problematic in shops #232

Closed Blaziken257 closed 4 months ago

Blaziken257 commented 6 months ago

Version

Seen in tr_EN+nightly.20240304 but possibly occurs in earlier versions too (but untested).

Description

Some parts have long descriptions that don't fit in two lines. In the parts screen, this is not too problematic since the player can just press A to advance the text. However, this isn't possible in shops, because pressing A gives a prompt to buy or sell parts before the text can finish. An example is shown with the Tricky part but this can occur with other parts too.

bgb06949bgb06950 bgb06951bgb06952

In addition, the text advancement indicator on the bottom right (the best indicator that the desciption is more than two lines) only appears inconsistently. Keep selecting and unselecting the problematic part and another part back and forth using the D-Pad, and it either persists being visible all the time or never being visible. It is likely that this particular screen wasn't designed to even support more than 2 lines of text.

A save file is attached right inside a shop. While this shop doesn't let you buy parts that have long descriptions, you can use the debug feature with Select to eventually find one that does have problematic parts. Medarot 3 - Kabuto Version (Japan) (EN 20240304) - Shop.zip

VariantXYZ commented 6 months ago

Partially resolved by #233

Indicator still needs to be fixed

Blaziken257 commented 6 months ago

This issue also happens to be present in the screen where you can view your Medabots. A save is provided to show an example. Press B -> Medarots -> Saurus -> Steam Dolin or Steam Pipe to see it.

bgb07562

Medarot 3 - Kabuto Version (Japan) (EN 20240406) - Steam Pipe.zip

VariantXYZ commented 4 months ago

https://github.com/Medabots/medarot3/assets/3066132/8b01e6bf-6624-40d1-870b-2b572aa851d6

Multi-line descriptions should be OK now in shops and the part screen.