Medabots / medarot3

Medarot 3 GBC disassembly/translation
27 stars 6 forks source link

Winning a mandatory robattle crashes the game #234

Closed Blaziken257 closed 3 months ago

Blaziken257 commented 3 months ago

Versions

First occurred in tr_EN+nightly.20240304 and still remains as of tr_EN+nightly.20240318. Tested on bgb. Issue doesn't occur in tr_EN+nightly.20240303 or earlier.

Description

When winning certain robattles, as soon as the robattle is over, the game crashes (and has several graphical glitches when crashing). This issue is not present when losing. One example is battling against Kogane in Chapter 3, among others. Due to this bug, it is impossible to progress past these robattles without using an earlier nightly build.

M3 Kogane Crash

Save

A Kabuto save is attached right before the robattle against Kogane.

If you're using Metabee to robattle, to win this one, use Medachange (Shift MC) and then use Drive B followed by Drive C, and watch it crash afterwards. (Otherwise, Kogane will keep setting up traps to damage Metabee and destroy its parts... which is also the way to lose this. Losing goes to a Game Over screen as expected.)

Medarot 3 - Kabuto Version (Japan) - Pre-Kogane.zip

VariantXYZ commented 3 months ago

Something in the Link changes is the most likely culprit.

VariantXYZ commented 3 months ago

Hmm, it is something in the link patch for sure, so I'll revert it for now and reintroduce it after debugging this.

Given how it behaves differently in English (left) vs Japanese (right), it's probably a change that unintentionally corrupted some data out of bounds: image

VariantXYZ commented 3 months ago

Yep. I loaded something from the new text area when we didn't have anything there, and that caused some trouble.