Medacorp / Luigi-s-Mansion

The Luigi's Mansion map for Minecraft: Java Edition.
MIT License
11 stars 0 forks source link

Poltergust near entities (even those it does nothing with) lags out game #72

Closed Dhranios closed 2 years ago

Dhranios commented 2 years ago

Describe the bug Whenever you vacuum or expel near a lot of entities, the game slows down a lot.

To Reproduce Steps to reproduce the behavior:

  1. Clear a room with a money-containing chest, without a mirror
  2. Open the chest with the Poltergust selected
  3. Notice the lag
  4. Deselect the Poltergust before items get grabbed
  5. Notice the server catching up, and then continuing normal speed

Expected behavior The Poltergust wouldn't lag out the server.

Map version: 4ab0ae8

Additional context Uncertain if also the case before recent changes to the Poltergust entity-interacting (which were made to make it work with marker entities/all entities in a 3 block range).

Dhranios commented 2 years ago

Can be improved by merging a bunch of the function tag's functions under a new tag (eg items, only running when the entity has tag=item)

Possible groupings:

Split files with more than 1 line into a 1-condition file under /effects like mouse and boolossus.

Apply same changes to dust, fire, water and ice.

EDIT: applied to vacuum only, others have way less possible interactions; this seemed to have little effect though