search

MediaArea / BWFMetaEdit

WAV/BWF metadata editor
https://MediaArea.net/BWFMetaEdit
Other
44 stars 19 forks source link

CLI: LoudnessValue is unknown #47

Closed X-Raym closed 6 years ago

X-Raym commented 6 years ago

Hi !

I'm trying to inject Loudness data from CLI, with --LoudnessValue="0" syntax,

but I only get an error message:

--loudnessvalue="0" is unknown.

According to source code, only some keywords are allowed: https://github.com/MediaArea/BWFMetaEdit/blob/master/Source/CLI/CommandLine_Parser.cpp#L445 .... and not loudness value.

But the LoudnessValue parameter is proposed by the bwfmetaedit --help

                        Fill files with:
--in-core=              data from the specified Core file
--in-core-remove        clear data (remove bext and INFO)
--BextVersion=          specified bext version
--Description=          specified bext description
--Originator=           specified bext originator
--OriginatorReference=  specified bext originator reference
--OriginationDate=      specified bext origination date
--OriginationTime=      specified bext origination time
--Timereference=        specified bext time reference
--UMID=                 specified bext umid
--LoudnessValue=        specified bext loundness value
--LoudnessRange=        specified bext loundness range
--MaxTruePeakLevel=     specified bext max true peak level
--MaxMomentaryLoudness= specified bext max mnomentary loundness
--MaxShortTermLoudness= specified bext maw short term loundness
--History=              specified bext history
--IARL=                 specified INFO IARL
--ISFT=                 specified INFO ISFT
--xxxx=                 specified INFO xxxx...

Are these Loudness and Peak keywords missing from the Parser ? Or is it a problem with the help ? Unless I'm simply missing something ?

Thanks again for your support !

X-Raym commented 6 years ago

I took a closer look, missing setters are:

--LoudnessValue=        specified bext loundness value
--LoudnessRange=        specified bext loundness range
--MaxTruePeakLevel=     specified bext max true peak level
--MaxMomentaryLoudness= specified bext max mnomentary loundness
--MaxShortTermLoudness= specified bext maw short term loundness

Best,

X-Raym commented 6 years ago

Ok I modified the source and I confirm adding this in the CLI parser file works (I tested all parameters with a new compiled version of the CLI):

     && Field!="loudnessvalue"
     && Field!="loudnessrange"
     && Field!="maxtruepeaklevel"
     && Field!="maxmomentaryloudness"
     && Field!="maxshorttermloudness"

I created a pull request for this file in particular.

https://github.com/MediaArea/BWFMetaEdit/pull/48

Thanks !