search

MediaArea / MediaConch

MediaConch (funded by PREFORMA)
31 stars 11 forks source link

add EBML-MINVER-COHERANT and EBML-MAXVER-COHERANT #195

Closed dericed closed 7 years ago

dericed commented 7 years ago

PR updated, @JeromeMartinez noticed an error due to me using > and < when I should have used >= and <=

JeromeMartinez commented 7 years ago

Still a problem with EBML-HEADER-ELEMENTS-WITHIN-MAXSIZELENGTH.mkv 

fail! EBML-HEADER-ELEMENTS-WITHIN-MAXSIZELENGTH.mkv
-- EBML-MINVER-COHERANT
-- [fail:FlagInterlaced is defined starting in version 2 but occurs in a Matroska file of version 1.]
-- [/Segment[1]/Tracks[1]/TrackEntry[1]/Video[1]/FlagInterlaced[1] at bytes offset of 313]
-- [fail:SimpleBlock is defined starting in version 2 but occurs in a Matroska file of version 1.]
-- [/Segment[1]/Cluster[1]/SimpleBlock[1] at bytes offset of 723]
-- [fail:SimpleBlock is defined starting in version 2 but occurs in a Matroska file of version 1.]
-- [/Segment[1]/Cluster[1]/SimpleBlock[2] at bytes offset of 3323]
-- [fail:SimpleBlock is defined starting in version 2 but occurs in a Matroska file of version 1.]
-- [/Segment[1]/Cluster[1]/SimpleBlock[3] at bytes offset of 3656]
-- EBML-HEADER-ELEMENTS-WITHIN-MAXSIZELENGTH
-- [fail:An Element of the EBML Header has an Element Data Size with a length greater than 4 octets.]
-- [ at bytes offset of 17]

I guess it is "normal" but we try to have only 1 error per test file.

dericed commented 7 years ago

Issue was with sample, not test. The sample is fixed in https://github.com/preforma/groundtruth/pull/18.